Add a list of potentially applicable extensions to every class page #2053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Screenshots:
|
scheglov
reviewed
Oct 31, 2019
lib/src/model.dart
Outdated
| Iterable<Extension> get potentiallyApplicableExtensions { | ||
| if (_potentiallyApplicableExtensions == null) { | ||
| if (name.contains('BaseTest')) { | ||
| print('hello'); |
There was a problem hiding this comment.
Do you want to keep this debug code?
There was a problem hiding this comment.
no, oops, will delete.
scheglov
reviewed
Oct 31, 2019
lib/src/model.dart
Outdated
| @@ -1326,6 +1350,28 @@ class Extension extends Container | |||
| ElementType.from(_extension.extendedType, library, packageGraph); | |||
| } | |||
|
|
|||
| /// Returns [true] if this extension could be applicable to any possible | |||
| /// instantiation of [c]. | |||
There was a problem hiding this comment.
This does not sound mathematically rigorous :-)
Maybe "...if there is an instantiation of [c] to which this extension could be applied".
There was a problem hiding this comment.
yes, better. Done.
scheglov
reviewed
Oct 31, 2019
| } | ||
| return a; | ||
| }).toList(), | ||
| nullabilitySuffix: classInstantiated.nullabilitySuffix); |
There was a problem hiding this comment.
Let's be explicit, use NullabilitySuffix.none.
There was a problem hiding this comment.
I would prefer to preserve whatever I was given rather than explicitly specify something potentially wrong.
scheglov
approved these changes
Oct 31, 2019
This was referenced Oct 31, 2019
bwilkerson
approved these changes
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The beginnings of a fix for @munificent's #2021. We do not currently display methods that are applicable (that will need to come in a followup), but can calculate which extensions at a top level are likely, via the type system, to have methods that can be applied.
There are problems with this PR including inefficient lookups in the case where many extensions are defined and reaching into private analyzer interfaces, both of which will need to be fixed in followups.